Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate datasource-streaming-websocket to create tool #83

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Migrate datasource-streaming-websocket to create tool #83

merged 3 commits into from
Sep 8, 2022

Conversation

academo
Copy link
Member

@academo academo commented Sep 1, 2022

No description provided.

@academo academo added the enhancement New feature or request label Sep 1, 2022
@academo academo self-assigned this Sep 1, 2022
@academo academo mentioned this pull request Sep 1, 2022
Closed
13 tasks
mckn
mckn approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Found one small nit but apart from that it should be good to go.

examples/datasource-streaming-websocket/streaming-websocket-plugin/package.json Outdated Show resolved Hide resolved
@academo academo merged commit 774ba75 into master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mckn mckn mckn approved these changes

@jackw jackw Awaiting requested review from jackw

@tolzhabayev tolzhabayev Awaiting requested review from tolzhabayev

Assignees

@academo academo

Labels
enhancement New feature or request
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@academo @mckn