Chore: Move last pieces from Grafana's legacydata package into the SDK #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marefr
requested review from
asimpson,
bossinc,
aangelisc,
adamyeats,
wbrowne,
andresmgot,
xnyo and
ryantxu
and removed request for
a team
ryantxu
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow up from grafana/grafana#88772 moving time range utilities to SDK existing gtime package and some conversion logic into experimental/apis/data/v0alpha1 so that we can completely remove the legacydata package in grafana.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Using latest commit of github.com/jszwedko/go-datemath instead of github.com/vectordotdev/go-datemath - the repository was renamed as far as I understand which is the only change between these two.