Revert upgrade of getkin/kin-openapi to v0.122.0 #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marefr
requested review from
wbrowne,
andresmgot and
oshirohugo
and removed request for
a team
wbrowne
approved these changes
Dec 4, 2023
andresmgot
reviewed
Dec 4, 2023
Comment on lines
+5
to
+6
| // The v0.120.0 is needed for now to be compatible with grafana/thema. | ||
| replace github.com/getkin/kin-openapi => github.com/getkin/kin-openapi v0.120.0 |
There was a problem hiding this comment.
I am not a fan of this replaces. I know it ensures that the specific version is used but it has happened to me that I have updated a dependency without realizing that there was a replace somewhere in the go.mod file. Isn't just enough to put this comment in the related require line?
There was a problem hiding this comment.
No strong opinions really, but in grafana we normally use replace with comment.
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too many issues with grafana/grafana#79021 and grafana/thema so reverting this for now.