build(deps): bump google.golang.org/grpc from 1.63.2 to 1.64.0 #990
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.63.2 to 1.64.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.63.2...v1.64.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
dependabot
bot
requested review from
wbrowne,
marefr and
xnyo
and removed request for
a team
| @@ -23,7 +23,7 @@ type TestPluginClient struct { | |||
| } | |||
|
|
|||
| func newTestPluginClient(addr string) (*TestPluginClient, error) { | |||
| c, err := grpc.Dial(addr, grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithBlock()) | |||
| c, err := grpc.NewClient(addr, grpc.WithTransportCredentials(insecure.NewCredentials())) | |||
There was a problem hiding this comment.
grpc.Dial is deprecated and grpc.NewClient should be used instead.
grpc.WithBlock() is an anti-pattern, and shouldn't be necessary in this case.
More info here: https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md
Additionally, all RPCs created on an "idle" or a "connecting" ClientConn will wait until their deadline or until a connection is established before failing. This means that you don't need to check that a ClientConn is "ready" before starting your RPCs.
|
@wbrowne @marefr I have fixed the CI failure due to deprecation warning, please take a look. We will also have to do similar changes in Grafana core when we bump grpc over there:
|
|
Great. I would suggest doing the changes in Grafana/grafana before merging this and validate that everything works as expected in regards to backend plugins, i.e the regular test with plugin using older grafana/newer sdk and newer grafana with old sdk in plugin etc. Thoughts? |
|
Sounds good, I will take care of that tomorrow 🙂 |
|
Bumped in core as well: |
Bumps google.golang.org/grpc from 1.63.2 to 1.64.0.
Release notes
Sourced from google.golang.org/grpc's releases.
Commits
fa274d7Change version to 1.64.0 (#7218)6b413c8xds: Surround twoInfofcalls that usepretty.ToJSONwithV(2)checks (...2dbbcefresolver/dns: Add docstring to SetMinResolutionInterval (#7217)070d9c7codes: replace %q to %d in error string when invalid code is an integer (#7188)5d24ee2xds: store server config for LRS server in xdsresource.ClusterUpdate (#7191)c76f686advancedTLS: Rename get root certs related pieces (#7207)f591e3bcodec: remove option to suppress setting supported compressors in headers (#7...b4f7947github: remove dependabot (#7208)0561c78client: add user-friendly error message of LB policy update timed out (#7206)9d9c1fbpeer: remove change detector test (#7204)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)