Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin's custom VariableQueryEditor is broken in master #16439

Closed
alexanderzobnin opened this issue Apr 8, 2019 · 0 comments
Closed

Plugin's custom VariableQueryEditor is broken in master #16439

alexanderzobnin opened this issue Apr 8, 2019 · 0 comments
Assignees
@torkelo
Labels
area/dashboard/templating type/bug
Milestone
6.2-beta1

Comments

@alexanderzobnin
Copy link
Contributor

After 47e51cb custom VariableQueryEditor doesn't work anymore.

What happened:
Default variable query editor appears even if plugin implements a custom one.

Screenshot from 2019-04-08 11-37-34

What you expected to happen:
Custom VariableQueryEditor should be loaded.

Screenshot from 2019-04-08 11-32-55

How to reproduce it (as minimally and precisely as possible):
Use any plugin that implements VariableQueryEditor, like builtin Stackdriver datasource.

Environment:

  • Grafana version: master (47e51cb)
  • Data source type & version: Stackdriver
  • OS Grafana is installed on:
  • User OS & Browser:
  • Grafana plugins:
  • Others:
@torkelo torkelo self-assigned this Apr 8, 2019
@torkelo torkelo added this to the 6.2 milestone Apr 8, 2019
@torkelo torkelo closed this as completed in 9630d81 Apr 8, 2019
ryantxu added a commit to ryantxu/grafana that referenced this issue Apr 9, 2019
@ryantxu
Merge remote-tracking branch 'grafana/master' into react-streaming
c8fc06c 
* grafana/master: (27 commits)
  docs: fixes and update current version
  Docs: Updated changelog for v6.1.3
  Graph: fixed png rendering with legend to the right (grafana#16463)
  Fix: Disables auto open datasource picker on focus (grafana#16398)
  add some mock/stub guidelines to testing guideline (grafana#16466)
  Feat: Suggestion list in Explore is virtualized (grafana#16342)
  Docs: Updated roadmap issue to link to the pinned roadmap issues
  Graph: Fixed auto decimals in legend values (grafana#16455)
  Styling: Aligned heading (grafana#16456)
  add PromQL keyword for adhoc filter (grafana#16426)
  Singlestat: Use decimal override when manually specified (grafana#16451)
  Graph: follow-up graph decimals fix, grafana#16414 (grafana#16450)
  Chore: use remote cache instead of session storage (grafana#16114)
  Docs: Minor changelog tweak
  Docs: Updated changelog with v6.1.2 release issues
  datasource: fix disable query when using mixed datasource (grafana#16409)
  Graph: Fixed series legend color for hidden series (grafana#16438)
  Templating: Fixed loading React variable query editor (grafana#16439)
  Styles: Fixed left menu highlight (grafana#16431)
  Fix: remove test artefact (grafana#16411)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torkelo torkelo

Labels
area/dashboard/templating type/bug
Projects
None yet
Milestone
6.2-beta1
Development

No branches or pull requests
2 participants
@torkelo @alexanderzobnin