Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph: fixed png rendering with legend to the right #16463

Merged
merged 1 commit into from Apr 9, 2019

Conversation

@torkelo
Copy link
Member

commented Apr 9, 2019

Upgraded autoprefixer changed the way flexbox prefixing is done

Before with autoprefixer 6.4.0

.graph-panel {
  display: -webkit-box;
  display: -ms-flexbox;
  display: flex;
  -webkit-box-orient: vertical;
  -webkit-box-direction: normal;
      -ms-flex-direction: column;
          flex-direction: column;
  height: 100%; }

With autoprefixer 9

.graph-panel {
  display: -webkit-box;
  display: -webkit-flex;
  display: -ms-flexbox;
  display: flex;
  -webkit-box-orient: vertical;
  -webkit-box-direction: normal;
  -webkit-flex-direction: column;
      -ms-flex-direction: column;
          flex-direction: column;
  height: 100%; }

Major difference is the new prefix display: -webkit-flex; after the display: -webkit-box;

This addition of the newer prefix standard caused the legend to the right to stop working.

Fixes #16443

@torkelo torkelo merged commit fed7569 into master Apr 9, 2019

2 checks passed

build-branches-and-prs Workflow: build-branches-and-prs
Details
license/cla Contributor License Agreement is signed.
Details

@torkelo torkelo deleted the phantomjs-graph-legend-fix branch Apr 9, 2019

@torkelo torkelo added this to the 6.1.3 milestone Apr 9, 2019

torkelo added a commit that referenced this pull request Apr 9, 2019
@torkelo torkelo referenced this pull request Apr 9, 2019
3 of 7 tasks complete
ryantxu added a commit to ryantxu/grafana that referenced this pull request Apr 9, 2019
Merge remote-tracking branch 'grafana/master' into react-streaming
* grafana/master: (27 commits)
  docs: fixes and update current version
  Docs: Updated changelog for v6.1.3
  Graph: fixed png rendering with legend to the right (grafana#16463)
  Fix: Disables auto open datasource picker on focus (grafana#16398)
  add some mock/stub guidelines to testing guideline (grafana#16466)
  Feat: Suggestion list in Explore is virtualized (grafana#16342)
  Docs: Updated roadmap issue to link to the pinned roadmap issues
  Graph: Fixed auto decimals in legend values (grafana#16455)
  Styling: Aligned heading (grafana#16456)
  add PromQL keyword for adhoc filter (grafana#16426)
  Singlestat: Use decimal override when manually specified (grafana#16451)
  Graph: follow-up graph decimals fix, grafana#16414 (grafana#16450)
  Chore: use remote cache instead of session storage (grafana#16114)
  Docs: Minor changelog tweak
  Docs: Updated changelog with v6.1.2 release issues
  datasource: fix disable query when using mixed datasource (grafana#16409)
  Graph: Fixed series legend color for hidden series (grafana#16438)
  Templating: Fixed loading React variable query editor (grafana#16439)
  Styles: Fixed left menu highlight (grafana#16431)
  Fix: remove test artefact (grafana#16411)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.