Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove test artefact #16411

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Conversation

markelog
Copy link
Contributor

@markelog markelog commented Apr 5, 2019

See #16200 (comment)
Thanks @xlson

Ref #16200

@markelog markelog requested a review from xlson April 5, 2019 12:12
@torkelo
Copy link
Member

torkelo commented Apr 7, 2019

Oh now, that is terrible :( now the repo is 60mb bigger forever :(

Need a pre-commit hook that blocks large files

@markelog
Copy link
Contributor Author

markelog commented Apr 7, 2019

Things are not that bad, the file weights 0 bytes - it's empty.

Pre-commit hook sounds like a good idea! Although --no-verify flag during the git commit has quite a popular use in my experience. We might consider implementing the check on the CI side? In a way that it would not fail the CI run however?

In any case what do you think the threshold should be?

@xlson xlson merged commit 99605d1 into grafana:master Apr 8, 2019
ryantxu added a commit to ryantxu/grafana that referenced this pull request Apr 9, 2019
* grafana/master: (27 commits)
  docs: fixes and update current version
  Docs: Updated changelog for v6.1.3
  Graph: fixed png rendering with legend to the right (grafana#16463)
  Fix: Disables auto open datasource picker on focus (grafana#16398)
  add some mock/stub guidelines to testing guideline (grafana#16466)
  Feat: Suggestion list in Explore is virtualized (grafana#16342)
  Docs: Updated roadmap issue to link to the pinned roadmap issues
  Graph: Fixed auto decimals in legend values (grafana#16455)
  Styling: Aligned heading (grafana#16456)
  add PromQL keyword for adhoc filter (grafana#16426)
  Singlestat: Use decimal override when manually specified (grafana#16451)
  Graph: follow-up graph decimals fix, grafana#16414 (grafana#16450)
  Chore: use remote cache instead of session storage (grafana#16114)
  Docs: Minor changelog tweak
  Docs: Updated changelog with v6.1.2 release issues
  datasource: fix disable query when using mixed datasource (grafana#16409)
  Graph: Fixed series legend color for hidden series (grafana#16438)
  Templating: Fixed loading React variable query editor (grafana#16439)
  Styles: Fixed left menu highlight (grafana#16431)
  Fix: remove test artefact (grafana#16411)
  ...
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants