Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v10.0.x] Alerting: Add file and rule_group query params in request for filtering the res… #70417

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

grafanabot
Copy link
Contributor

Backport e6243f7 from #70379


What is this feature?
This PR introduces some changes to the RuleViewer page by adding new query parameters for filtering alert rules based on file (namespace) and rule_group. These additions effectively reduce the number of rules loaded on the page, resulting in improved loading times.

Initially, the plan was to incorporate the new rule_name query parameter introduced in this PR. However, to maintain compatibility with existing links to the view and considering the absence of alert names in those links, an alternative approach was necessary.

By introducing the file and rule_group query parameters, we achieve the desired improvements in loading time and enhance the overall performance of the RuleViewer page.

This is only implemented for cloud rules.

Why do we need this feature?

We need to prevent the unnecessary loading of all rules when only one rule is being accessed.

Who is this feature for?

All users.
Which issue(s) does this PR fix?:

This PR fixes partially (FE side) this issue

Special notes for your reviewer:

filterbygroupandfile.mp4

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

…ng the res… (#70379)

* Add file and rule_group query params in request for filtering the response when loading rule in view mode

* Fix test

(cherry picked from commit e6243f7)
@gillesdemey gillesdemey modified the milestone: 10.0.x Jun 21, 2023
@gillesdemey gillesdemey merged commit f7b4f70 into v10.0.x Jun 21, 2023
@gillesdemey gillesdemey deleted the backport-70379-to-v10.0.x branch June 21, 2023 12:16
@zerok zerok modified the milestones: 10.0.x, 10.0.2 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants