Plugins: Add feature toggle for Temporary Credentials #71033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idastambuk
requested review from
summerwollin and
mmandrus
and removed request for
a team
grafanabot
added
area/backend
area/frontend
type/docs
mmandrus
approved these changes
Jul 5, 2023
We don't have one yet, but there's a task for it. |
idastambuk
force-pushed
the
203-temporary-credentials-create-a-feature-toggle
branch
from
2a48e20
to
f002772
Compare
katebrenner
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
LGTM! nit for a separate PR: We should update https://github.com/grafana/grafana/blob/main/pkg/services/featuremgmt/codeowners.go#L23 to be @grafana/aws-datasources
Pushed another commit for this☝🏻 |
sarahzinger
approved these changes
Jul 6, 2023
polibb
pushed a commit
that referenced
this pull request
Jul 14, 2023
* Add feature toggle * Change team name in codeowners file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adds a feature flag awsDatasourcesTempCredentials for the planned Temporary Credentials feature for Grafana Cloud.
Which issue(s) does this PR fix?:
Fixes https://github.com/grafana/oss-plugin-partnerships/issues/203
Special notes for your reviewer:
Please check that: