Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traces: Enable showing trace ids #71950

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Traces: Enable showing trace ids #71950

merged 2 commits into from
Jul 20, 2023

Conversation

gabor
Copy link
Contributor

@gabor gabor commented Jul 19, 2023

this feature was behind the experimental showTraceId feature flag until now, now we are removing the feature toggle and enabling it by default.

how to test:
to have grafana-backend generatea traceids, add something like this to the grafana config file:

[tracing.opentelemetry.jaeger]
address = http://localhost:1234
propagation = jaeger

note, nothing has to run at the specified address (localhost:1234) in this case, to be able to test the change.

  1. run a query that does not fail, like a loki query or prometheus query. after you run it, open the query inspector, go to the stats-tab, scroll to the bottom, and verify that the traceId is shown there.
  2. run a query, for example a loki or prometheus query, and make a syntax error in it. for example this loki query : {a="42"} haha
    • verify that the traceid is added to the end of the arriving error message
    • go to the query inspector's error tab, and verify that you can see the traceid at the end of the error message here too.
    • go to the query inspector's stats tab, scroll to the bottom, and verify that you can see the traceid here too.

@gabor gabor requested review from grafanabot and a team as code owners July 19, 2023 13:59
@gabor gabor requested review from leandro-deveikis, mmandrus, dprokop, juanicabanas and a team and removed request for a team July 19, 2023 13:59
@gabor gabor added this to the 10.1.x milestone Jul 19, 2023
@gabor gabor added no-backport Skip backport of PR add to changelog labels Jul 19, 2023
@gabor gabor changed the title Traces: Enable showing trace ids by default Traces: Enable showing trace ids Jul 19, 2023
@grafanabot grafanabot added area/frontend area/backend type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project labels Jul 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

⚠️   Possible breaking changes

(Open the links below in a new tab to go to the correct steps)

grafana-data has possible breaking changes (more info)

Console output
Read our guideline

@grafanabot grafanabot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Jul 19, 2023
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☄️

@gabor gabor merged commit 2c82a6b into main Jul 20, 2023
@gabor gabor deleted the gabor/remove-traceid-toggle branch July 20, 2023 05:59
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/backend area/frontend levitate breaking change A label indicating a breaking change and assigned by Levitate. no-backport Skip backport of PR type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants