Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: Split name column in search results #72449

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Conversation

joey-grafana
Copy link
Contributor

@joey-grafana joey-grafana commented Jul 27, 2023

What is this feature?

Changes the trace name column in the trace results table.

Why do we need this feature?

Make it clearer which value is the trace name and which is the service name.

Who is this feature for?

Tracing users.

Which issue(s) does this PR fix?:

Fixes #70932

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@joey-grafana joey-grafana marked this pull request as ready for review July 28, 2023 10:00
@joey-grafana joey-grafana requested a review from a team as a code owner July 28, 2023 10:00
@joey-grafana joey-grafana merged commit e6c96e7 into main Aug 14, 2023
9 checks passed
@joey-grafana joey-grafana deleted the joey/split-name-column branch August 14, 2023 12:26
bergquist added a commit that referenced this pull request Aug 15, 2023
* main: (233 commits)
  PublicDashboards: Query order bug fixed (#73293)
  PostgreSQL: bump lib/pq to latest version (#72416)
  InfluxDB: Tests for #73247 (#73250)
  Docs: Add plugin dev documentation for logs to trace (#73225)
  Alerting: Update state manager to change all current states in the case when Error\NoData is executed as Ok\Nomal (#68142)
  Docs: correct SAML docs (#73281)
  CloudWatch: Add missing AppFlow metrics (#73149)
  docs: What’s New & Upgrade Guide 10.1 (#70636)
  Dashboard: Fix repeated row panel placement with larger number of rows (#72011)
  Geomap: Fix crosshair glitch (#72909)
  Logs: Fix scrolling with `exploreScrollableLogsContainer` feature (#73272)
  CodeEditor: Correctly fires onChange handler (#73030)
  InfluxDB: make influxql options the default if nothing defined (#73247)
  Cloudwatch: Upgrade aws-sdk and display external ids for temporary credentials (#72821)
  Cloudwatch: reorg files in components (#73176)
  Elasticsearch: Enable running of queries trough data source backend (#73222)
  Chore: fix some more types (#72726)
  Loki: Migrate HTTP settings to new components (#72831)
  Tracing: Split name column in search results (#72449)
  Plugins: Remove unnecessary error result from env vars interface (#73224)
  ...
aishyandapalli pushed a commit to aishyandapalli/grafana that referenced this pull request Aug 16, 2023
* Split name column

* Add tests

* Update test
chauchausoup pushed a commit to chauchausoup/grafana that referenced this pull request Sep 15, 2023
* Split name column

* Add tests

* Update test
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tempo: The contents of the Name column in search results can be a little confusing
3 participants