Dashboard: Store original JSON in DashboardModel #73881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarity-89
requested review from
ashharrison90,
JoaoSilvaGrafana,
polibb,
lucychen-grafana and
torkelo
and removed request for
a team,
polibb and
lucychen-grafana
Clarity-89
commented
Aug 28, 2023
torkelo
requested review from
dprokop,
ivanortegaalba and
kaydelaney
and removed request for
ashharrison90 and
JoaoSilvaGrafana
dprokop
reviewed
Aug 28, 2023
There was a problem hiding this comment.
Looks good.
Thought - do we need to save in in Store? For the sake of simplicity, maybe just having it as a private property with a getter on DashboardModel would be sufficient, given the original dashboard is already passed in there via constructor, and dashboard model is available downstream the components on Dashboard page.
That's a good point and should make the code a bit simpler. |
dprokop
reviewed
Aug 29, 2023
dprokop
approved these changes
Aug 29, 2023
Clarity-89
changed the title
chauchausoup
pushed a commit
to chauchausoup/grafana
that referenced
this pull request
Sep 15, 2023
* Dashboard: Save original JSON to state * Dashboards: Update tests * Dashboards: Fix original json access * Dashboard: Save original to the DashboardModel * Dashboard: Cleanup tests * Remove original db setter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Save the original dashboard JSON inside the DashboardModel instead of making an extra API request to fetch it when saving.
Why do we need this feature?
Removes an extra API request for fetching dashboard JSON when checking if there were any changes to the dashboard on save.
Special notes for your reviewer:
Please check that: