Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders: Do not allow modifying the folder UID via the API #74684

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

papagian
Copy link
Contributor

What is this feature?

It modifies PUT /api/folders/:uid and drops support for updating the folder UID.

Why do we need this feature?

We used to allow updating the folder UID via the API. However, UIDs are expected to be immutable.

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes partially #60983

Special notes for your reviewer:

Swagger/OpenAPI docs are re-generated and contain also changes not related to the present ticket.

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

Release notice breaking change

The PUT /api/folders/:uid endpoint no more supports modifying the folder's UID.

@papagian papagian added add to changelog breaking change Relevant for changelog generation no-backport Skip backport of PR labels Sep 11, 2023
@papagian papagian requested review from a team and Eve832 as code owners September 11, 2023 15:41
@papagian papagian requested review from zserge, mildwonkey and suntala and removed request for a team September 11, 2023 15:41
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Sep 11, 2023
@grafana-pr-automation grafana-pr-automation bot added type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project area/frontend area/backend labels Sep 11, 2023
@papagian papagian merged commit 376f9a7 into main Sep 12, 2023
22 checks passed
@papagian papagian deleted the papagian/do-not-change-folder-uid branch September 12, 2023 11:28
chauchausoup pushed a commit to chauchausoup/grafana that referenced this pull request Sep 15, 2023
…4684)

* Folders: Do not allow changing the folder UID via the API

* Update Swagger/OpenAPI docs

* Update HTTP API docs
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
julienduchesne added a commit to grafana/terraform-provider-grafana that referenced this pull request Oct 27, 2023
julienduchesne added a commit to grafana/terraform-provider-grafana that referenced this pull request Oct 30, 2023
See grafana/grafana#74684
In Grafana 10.2, the API goes away
julienduchesne added a commit to grafana/terraform-provider-grafana that referenced this pull request Oct 31, 2023
See grafana/grafana#74684
In Grafana 10.2, the API goes away
julienduchesne added a commit to grafana/terraform-provider-grafana that referenced this pull request Oct 31, 2023
See grafana/grafana#74684
In Grafana 10.2, the API goes away
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/backend area/frontend breaking change Relevant for changelog generation no-backport Skip backport of PR type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants