-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboards: Add template variables to selectable options #75870
Conversation
public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall feel like this a solid improvement 👍
Tag values would show No options found
until the user had selected a tag key. I like that approach as the users knows that the values map to the key selected. Here we are pre-populating the values with the template variables. Perhaps it would improve UX to only show the template variables in the tag values when a tag key is selected? I'm not overly convinced of this approach but am not thinking of another this minute!
public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.test.tsx
Show resolved
Hide resolved
public/app/plugins/datasource/tempo/SearchTraceQLEditor/SearchField.tsx
Outdated
Show resolved
Hide resolved
Improvements look good 👍 You may be working on this, what do you think about my comment regarding |
Yeah I wanted to have another thought on that today, because I also don't have a strong opinion on whether to keep the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd say it's not a necessary change to make right now.
Add template variables to the options of
Select
fields for the Search tab for the Tempo datasource. Example:Fixes #74210