Server: Automatically generate a self-signed TLS cert if needed #78243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut a provided cert
DanCech
requested review from
papagian,
zserge and
yangkb09
and removed request for
a team
ryantxu
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running Grafana in https (tls) or http2 mode the user must provide a TLS certificate and private key.
This PR adds the ability for Grafana to generate a self-signed certificate automatically if the user does not provide a certificate or key file.
If either certificate or key file are specified the old behavior is unchanged, with an error produced if one is provided without the other, the specified files do not exist, etc.
As part of this update the certificate loading code between
configureHttpsandconfigureHttp2has also been moved out into a sharedtlsCertificateshelper.