Transformations: Use an explicit join seperator when converting from an array to string field #80169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
requested review from
a team,
codeincarnate and
oscarkilhed
and removed request for
a team
ryantxu
commented
Jan 8, 2024
packages/grafana-data/src/transformations/transformers/reduce.ts
Outdated
Show resolved
Hide resolved
grafana-pr-automation
bot
requested review from
a team and
oshirohugo
and removed request for
a team
ryantxu
commented
Jan 9, 2024
| @@ -224,6 +224,7 @@ export function reduceFields(data: DataFrame[], matcher: FieldMatcher, reducerId | |||
| const value = results[reducer]; | |||
| const copy = { | |||
| ...field, | |||
| type: guessFieldTypeFromValue(value), | |||
There was a problem hiding this comment.
matches the behavior we have in reduceSeriesToRows(...) rather than always keeping the same type!
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
codeincarnate
approved these changes
Jan 9, 2024
| <> | ||
| {(c.joinWith?.length || targetField?.type === FieldType.other) && ( | ||
| <InlineField label="Join with" tooltip="Use an explicit separator when joining array values"> | ||
| <Input value={c.joinWith} placeholder={'json'} onChange={onJoinWithChange(idx)} width={9} /> |
There was a problem hiding this comment.
JSON I believe is all caps.
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
zserge
pushed a commit
that referenced
this pull request
Jan 22, 2024
…an array to string field (#80169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows people more control over the object > string conversion function. Currently it is just JSON encoded, this PR allows specifying an explicit separator for arrays.
Panel debug snapshot dashboard
{ "panels": [ { "datasource": { "type": "grafana", "uid": "grafana" }, "fieldConfig": { "defaults": { "custom": { "align": "auto", "cellOptions": { "type": "auto" }, "inspect": false }, "unitScale": true, "mappings": [], "thresholds": { "mode": "absolute", "steps": [ { "color": "green", "value": null }, { "color": "red", "value": 80 } ] }, "color": { "mode": "thresholds" } }, "overrides": [] }, "gridPos": { "h": 13, "w": 15, "x": 0, "y": 0 }, "id": 2, "options": { "showHeader": true, "cellHeight": "sm", "footer": { "show": false, "reducer": [ "sum" ], "countRows": false, "fields": "" } }, "pluginVersion": "10.3.0-pre", "targets": [ { "refId": "A", "datasource": { "type": "grafana", "uid": "grafana" }, "queryType": "snapshot", "snapshot": [ { "schema": { "refId": "A", "fields": [ { "name": "TheValues", "type": "string", "typeInfo": { "frame": "string", "nullable": true }, "config": {} } ] }, "data": { "values": [ [ "aaa", "bbb", "aaa", "ccc" ] ] } } ] } ], "title": "Reproduced with embedded data", "transformations": [ { "id": "reduce", "options": { "includeTimeField": false, "mode": "reduceFields", "reducers": [ "uniqueValues" ] } }, { "id": "convertFieldType", "options": { "fields": {}, "conversions": [ { "destinationType": "string", "joinWith": "|", "targetField": "TheValues" } ] } } ], "type": "table" }, { "gridPos": { "h": 7, "w": 9, "x": 15, "y": 0 }, "id": 5, "options": { "content": "<table width=\"100%\">\n <tr>\n <th width=\"2%\">Panel</th>\n <td >table @ 10.3.0-pre</td>\n </tr>\n <tr>\n <th>Queries</th>\n <td>A[grafana-testdata-datasource]</td>\n </tr>\n <tr>\n <th>Transform</th>\n <td>reduce, convertFieldType</td>\n </tr>\n <tr><th>Data</th><td> 1 frames, 1 fields, 4 rows </td></tr>\n \n <tr>\n <th>Grafana</th>\n <td>10.3.0-pre (6fbd6e3d310) // Enterprise</td>\n </tr>\n </table>", "mode": "html" }, "title": "Debug info", "type": "text" }, { "id": 6, "title": "Original Panel JSON", "type": "text", "gridPos": { "h": 13, "w": 9, "x": 15, "y": 7 }, "options": { "content": "{\n \"datasource\": {\n \"uid\": \"PD8C576611E62080A\",\n \"type\": \"grafana-testdata-datasource\"\n },\n \"fieldConfig\": {\n \"defaults\": {\n \"custom\": {\n \"align\": \"auto\",\n \"cellOptions\": {\n \"type\": \"auto\"\n },\n \"inspect\": false\n },\n \"unitScale\": true,\n \"mappings\": [],\n \"thresholds\": {\n \"mode\": \"absolute\",\n \"steps\": [\n {\n \"color\": \"green\",\n \"value\": null\n },\n {\n \"color\": \"red\",\n \"value\": 80\n }\n ]\n },\n \"color\": {\n \"mode\": \"thresholds\"\n }\n },\n \"overrides\": []\n },\n \"gridPos\": {\n \"h\": 8,\n \"w\": 12,\n \"x\": 0,\n \"y\": 0\n },\n \"id\": 1,\n \"options\": {\n \"showHeader\": true,\n \"cellHeight\": \"sm\",\n \"footer\": {\n \"show\": false,\n \"reducer\": [\n \"sum\"\n ],\n \"countRows\": false,\n \"fields\": \"\"\n }\n },\n \"pluginVersion\": \"10.3.0-pre\",\n \"targets\": [\n {\n \"scenarioId\": \"csv_content\",\n \"refId\": \"A\",\n \"datasource\": {\n \"type\": \"grafana-testdata-datasource\",\n \"uid\": \"PD8C576611E62080A\"\n },\n \"csvContent\": \"TheValues\\naaa\\nbbb\\naaa\\nccc\"\n }\n ],\n \"title\": \"Panel Title\",\n \"transformations\": [\n {\n \"id\": \"reduce\",\n \"options\": {\n \"includeTimeField\": false,\n \"mode\": \"reduceFields\",\n \"reducers\": [\n \"uniqueValues\"\n ]\n }\n },\n {\n \"id\": \"convertFieldType\",\n \"options\": {\n \"fields\": {},\n \"conversions\": [\n {\n \"destinationType\": \"string\",\n \"joinWith\": \"|\",\n \"targetField\": \"TheValues\"\n }\n ]\n }\n }\n ],\n \"type\": \"table\"\n}", "mode": "code", "code": { "language": "json", "showLineNumbers": true, "showMiniMap": true } } }, { "id": 3, "title": "Data from panel above (after transformations)", "type": "table", "datasource": { "type": "datasource", "uid": "-- Dashboard --" }, "gridPos": { "h": 7, "w": 15, "x": 0, "y": 13 }, "options": { "showTypeIcons": true }, "targets": [ { "datasource": { "type": "datasource", "uid": "-- Dashboard --" }, "panelId": 2, "withTransforms": true, "refId": "A" } ] }, { "id": 100, "title": "Data (before transformations)", "type": "table", "datasource": { "type": "datasource", "uid": "-- Dashboard --" }, "gridPos": { "h": 7, "w": 24, "x": 0, "y": 13 }, "options": { "showTypeIcons": true }, "targets": [ { "datasource": { "type": "datasource", "uid": "-- Dashboard --" }, "panelId": 2, "withTransforms": false, "refId": "A" } ] } ], "schemaVersion": 37, "title": "Debug: Panel Title // 2024-01-08 10:52:43", "tags": [ "debug", "debug-table" ], "time": { "from": "2024-01-08T12:52:43.703Z", "to": "2024-01-08T18:52:43.703Z" } }