Alerting: Swap order between Annotations and Labels step in the alert rule form. #81060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update some texts
soniaAguilarPeiron
added
area/alerting
soniaAguilarPeiron
requested review from
gillesdemey,
konrad147 and
brendamuir
and removed request for
a team
|
I think we should update docs , right? @brendamuir |
brendamuir
approved these changes
Jan 23, 2024
soniaAguilarPeiron
changed the title
dhalachliyski
approved these changes
Jan 23, 2024
| case Annotation.panelID: | ||
| label = ''; | ||
| break; | ||
| default: |
There was a problem hiding this comment.
I wonder why dashboardUID has Dashboard and panel label while panelID is empty?
There was a problem hiding this comment.
good question @konrad147 . Because we want to show the label only for the dashboard item.
See screenshots above, in case of panel field, we don't want to show any label (because we show the dashboard and panel selected next to the dashboard field)
konrad147
approved these changes
Jan 25, 2024
| case Annotation.panelID: | ||
| label = ''; | ||
| break; | ||
| default: |
There was a problem hiding this comment.
I wonder why dashboardUID has Dashboard and panel label while panelID is empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR change the order in steps in the alert rule form and updates some texts. (Same change is done in the Modfiy export form)
This PR also fix data source and panel label not being correct.
Before the change we had:
4. Add annotations
5. Labels and notifications
After the change:
4. Configure labels and notifications
5. Add annotations
Why do we need this feature?
We need to provide the best user experience, and with this change we think users can go through the steps in a more logical way.
Who is this feature for?
All users.
Special notes for your reviewer:
Recording rules are not affected:
Before the data source and panel label fix:
After the data source and panel label fix:
Please check that: