Chore: Update arrow and prometheus dependencies #82215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
commented
Feb 8, 2024
| @@ -336,7 +336,7 @@ func (n *Manager) Send(alerts ...*Alert) { | |||
| } | |||
| }) | |||
|
|
|||
| a.Labels = lb.Labels(a.Labels) | |||
| a.Labels = lb.Labels() | |||
There was a problem hiding this comment.
@grafana/alerting-backend-product -- the prometheus upgrade no longer has this function, but also the previous logic did not make sense. And I don't see any test :(
ryantxu
commented
Feb 8, 2024
go.mod
Outdated
| @@ -63,7 +63,7 @@ require ( | |||
| github.com/grafana/cuetsy v0.1.11 // @grafana/grafana-as-code | |||
| github.com/grafana/grafana-aws-sdk v0.23.1 // @grafana/aws-datasources | |||
| github.com/grafana/grafana-azure-sdk-go v1.12.0 // @grafana/partner-datasources | |||
| github.com/grafana/grafana-plugin-sdk-go v0.208.0 // @grafana/plugins-platform-backend | |||
| github.com/grafana/grafana-plugin-sdk-go v0.209.1-0.20240208231327-bb7c8753e380 // @grafana/plugins-platform-backend | |||
There was a problem hiding this comment.
^^ will be replaced with a real version after the PR is merged
There was a problem hiding this comment.
When the PR is merged you mean?
There was a problem hiding this comment.
There was a problem hiding this comment.
v0.210.0 released, you can update this.
There was a problem hiding this comment.
We will do it on Tuesday
|
/deploy-to-hg |
|
|
ryantxu
requested review from
a team,
wbrowne,
andresmgot and
xnyo
and removed request for
a team
|
Alerting bits LGTM, thanks! |
andresmgot
approved these changes
Feb 12, 2024
itsmylife
requested review from
rwwiv,
JacobsonMT,
yuri-tceretian,
grobinson-grafana,
papagian,
diegommm and
undef1nd
and removed request for
a team
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
* update arrow and prometheus * keep codeowner * use compare * use grafana-plugin-sdk-go v0.210.0 --------- Co-authored-by: ismail simsek <ismailsimsek09@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SDK to a version with latest arrow files. While doing the import -- it seems to also require upgrades to
/x/expand by extension prometheus 😬prometheus/prometheus#12649
Without the prometheus update, the error was: