[v10.4.x] Alerting: Add "Keep Last State" backend functionality #84406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
* Implement keep last state for state transitions * Respect For duration when keeping state * Only keep transition from recording an annotation * Add keep last state option for nodata/error in UI (cherry picked from commit 10dc6c6)
grafana-delivery-bot
bot
requested review from
Clarity-89 and
JoaoSilvaGrafana
and removed request for
a team
grafana-delivery-bot
bot
added
add to changelog
area/alerting
grafana-delivery-bot
bot
requested review from
gillesdemey,
tomratcliffe,
konrad147,
soniaAguilarPeiron,
rwwiv,
JacobsonMT,
yuri-tceretian and
grobinson-grafana
and removed request for
a team
rwwiv
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 10dc6c6 from #83940
What is this feature?
This PR adds the backend functionality that emulates the "keep last state" feature from legacy alerting in Grafana managed alerting (GMA).
Setting either NoDataState or ExecutionErrorState to
KeepLastwill persist the previous state of the alert instance and set the state reason to a concatenation of the evaluation result andKeepLast, e.g.NoData, KeepLast. This will respect the pending period (for) of a rule, which in practice means that associated alert instances will move to theAlertingstate if thePendingstate is kept for long.Some examples:
[Normal] => [Normal], t1:[NoData] => [Normal], t2:[NoData] => [Normal]for=2- t0:[Alerting] => [Pending], t1:[NoData] => [Pending], t2:[NoData] => [Alerting]Why do we need this feature?
This allows users to avoid being notified of no data and error evaluations on their alert rules.
Who is this feature for?
Users of Grafana managed alerting.
Which issue(s) does this PR fix?:
Resolves #82585
Related to #77800
Special notes for your reviewer:
Please check that: