Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenes: Fix public dashboard email sharing section #84467

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Scenes: Fix public dashboard email sharing section #84467

merged 2 commits into from
Mar 20, 2024

Conversation

juanicabanas
Copy link
Contributor

@juanicabanas juanicabanas commented Mar 14, 2024 •
edited
Loading

What is this feature?

When opening Public Dashboard tab with scenes enabled, it gets broken.

image

Which issue(s) does this PR fix?:

Fixes #84466

Special notes for your reviewer:

Part of Scenes Milestone 2 - Bug Bash

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@juanicabanas juanicabanas added this to the 11.0.x milestone Mar 14, 2024
@juanicabanas juanicabanas requested a review from a team as a code owner March 14, 2024 13:08
@juanicabanas juanicabanas requested review from AgnesToulet, mauigrl05, a team, mdvictor and kaydelaney and removed request for a team March 14, 2024 13:08
@juanicabanas juanicabanas merged commit 98a6b5d into main Mar 20, 2024
14 checks passed
@juanicabanas juanicabanas deleted the juanicabanas/pubdash-email-sharing-scenes-fix branch March 20, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evictorero evictorero evictorero approved these changes

@AgnesToulet AgnesToulet Awaiting requested review from AgnesToulet AgnesToulet is a code owner automatically assigned from grafana/sharing-squad

@mauigrl05 mauigrl05 Awaiting requested review from mauigrl05 mauigrl05 is a code owner automatically assigned from grafana/sharing-squad

@mdvictor mdvictor Awaiting requested review from mdvictor mdvictor was automatically assigned from grafana/dashboards-squad

@kaydelaney kaydelaney Awaiting requested review from kaydelaney kaydelaney was automatically assigned from grafana/dashboards-squad

Assignees
No one assigned
Labels
add to changelog area/frontend area/public-dashboards area/scenes type/bug
Projects
Dashboards
Archived in project
Milestone
11.0.0-preview
Development

Successfully merging this pull request may close these issues.

Public Dashboards: Fix email sharing component when scenes is enabled
3 participants
@juanicabanas @evictorero @fabrizio-grafana