Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use package libfontconfig1, instead of libfontconfig #16548

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Use package libfontconfig1, instead of libfontconfig #16548

merged 1 commit into from
Apr 15, 2019

Conversation

dhoppe
Copy link
Contributor

@dhoppe dhoppe commented Apr 12, 2019

What this PR does / why we need it:
Use the correct package name. The package libfontconfig does not exist at Debian and Ubuntu:

vagrant@debian-8:~$ apt search libfontconfig
Sorting... Done
Full Text Search... Done
libfontconfig1/oldstable,oldstable 2.11.0-6.3+deb8u1 amd64
  generic font configuration library - runtime

libfontconfig1-dbg/oldstable,oldstable 2.11.0-6.3+deb8u1 amd64
  generic font configuration library - debugging symbols

libfontconfig1-dev/oldstable,oldstable 2.11.0-6.3+deb8u1 amd64
  generic font configuration library - development

The installation only works because apt automatically corrects the package name:

vagrant@debian-8:~$ sudo apt install libfontconfig
Reading package lists... Done
Building dependency tree
Reading state information... Done
Note, selecting 'libfontconfig1' instead of 'libfontconfig'
The following extra packages will be installed:
  fontconfig-config fonts-dejavu-core
The following NEW packages will be installed:
  fontconfig-config fonts-dejavu-core libfontconfig1
0 upgraded, 3 newly installed, 0 to remove and 94 not upgraded.
Need to get 0 B/1,650 kB of archives.
After this operation, 3,879 kB of additional disk space will be used.
Do you want to continue? [Y/n]

Special notes for your reviewer:
The dependency has already been correctly configured in the following file:

@bergquist
Copy link
Contributor

Thank you for contributing to Grafana! :)

@bergquist bergquist merged commit 1538351 into grafana:master Apr 15, 2019
ryantxu added a commit to ryantxu/grafana that referenced this pull request Apr 15, 2019
* grafana/master:
  Docs: minor docs update for old urls
  Chore: Add more explicit typing (grafana#16594)
  Chore: Lowered implicit anys limit to 5977
  Chore: Adds typings to lodash (grafana#16590)
  PanelEditor: Change Queries heading to Query (grafana#16536)
  Security: Store datasource passwords encrypted in secureJsonData (grafana#16175)
  More development dashboards (grafana#16550)
  build: upgrades to golang 1.12.4 (grafana#16545)
  Use package libfontconfig1, instead of libfontconfig (grafana#16548)
  Adjust Send on all alerts to default label (grafana#16554)
  Chore: Lower limit of implicit anys to 6676
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants