More development dashboards #16550
More development dashboards #16550
Conversation
| @@ -4,6 +4,6 @@ providers: | |||
| - name: 'gdev dashboards' | |||
| folder: 'gdev dashboards' | |||
| type: file | |||
| updateIntervalSeconds: 15 | |||
| updateIntervalSeconds: 60 | |||
There was a problem hiding this comment.
wont this just be frustrating when working with dashboards?
I think all devs runs SSD nowdays and the content should almost always be cached. scanning a few files are very very very fast :)
There was a problem hiding this comment.
yea I increased it a bit after testing with many folders defined here (each have it's own interval) and the log spamming was a bit too much. And if we end up with a lot of dashboards parsing all those json files is going to eat up a lot cpu. The way the scanning works provisioning update cycles are far from cheap, having to deserialize all dashboards, and to hashed checksum on content, at least.
Set to 3s with 1300 dashboards it eats 100% according to this user: #16118
There was a problem hiding this comment.
But that 100% could be due to something else, maybe huge > megabytes big json dashboards (can happen)
|
Interesting idea. But couldn't that be considered information leakage? |
Sort of, especially if we include the full path (which ExternalId does contain) so you would see where on disk dashboards files are located. So we could strip out the first parts and only paths after the root provisioned path (but the logic for that could be a bit tricky). Just think the updating a provisioned dashboard step is still pretty complicated as there is currently no hints on what file I need to update. A pretty major oversight in the workflow. |
|
yea your absolutly right. |
* grafana/master: Docs: minor docs update for old urls Chore: Add more explicit typing (grafana#16594) Chore: Lowered implicit anys limit to 5977 Chore: Adds typings to lodash (grafana#16590) PanelEditor: Change Queries heading to Query (grafana#16536) Security: Store datasource passwords encrypted in secureJsonData (grafana#16175) More development dashboards (grafana#16550) build: upgrades to golang 1.12.4 (grafana#16545) Use package libfontconfig1, instead of libfontconfig (grafana#16548) Adjust Send on all alerts to default label (grafana#16554) Chore: Lower limit of implicit anys to 6676
While working on this I came up with a provisioning enhancement. Show ExternalId (path on disk) in the save modal for provisioned dashboards.
thoughts @bergquist ^
The home / overview dashboard:
