Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Adds types to lodash #16590

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Chore: Adds types to lodash #16590

merged 1 commit into from
Apr 15, 2019

Conversation

hugohaggmark
Copy link
Contributor

What this PR does / why we need it:
This PR reduces implicit anys by introducing typings for lodash.

Which issue(s) this PR fixes:
Progress #14714

@hugohaggmark hugohaggmark self-assigned this Apr 15, 2019
@torkelo
Copy link
Member

torkelo commented Apr 15, 2019

Nice!!!!!

@torkelo
Copy link
Member

torkelo commented Apr 15, 2019

LGTM

@hugohaggmark hugohaggmark merged commit 7eabc28 into master Apr 15, 2019
@hugohaggmark hugohaggmark deleted the hugoh/lodash-typings branch April 15, 2019 10:12
ryantxu added a commit to ryantxu/grafana that referenced this pull request Apr 15, 2019
* grafana/master:
  Docs: minor docs update for old urls
  Chore: Add more explicit typing (grafana#16594)
  Chore: Lowered implicit anys limit to 5977
  Chore: Adds typings to lodash (grafana#16590)
  PanelEditor: Change Queries heading to Query (grafana#16536)
  Security: Store datasource passwords encrypted in secureJsonData (grafana#16175)
  More development dashboards (grafana#16550)
  build: upgrades to golang 1.12.4 (grafana#16545)
  Use package libfontconfig1, instead of libfontconfig (grafana#16548)
  Adjust Send on all alerts to default label (grafana#16554)
  Chore: Lower limit of implicit anys to 6676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants