Plugins: better warning when plugins fail to load #18671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the plugin loader shows a "plugin not found" warning for any error error. See #grafana/piechart-panel#188. There should be a different error for plugins that exist, but we failed to load the module. This PR shows:
The most likely cause is people checking out a plugin from a github repository that does not include a compiled version.
This also changes the signature of
<AlertBox ...
so that it takes a ReactNode rather than just textThis also includes some startup WARN loggings if external plugins don't have an
module.js
: