Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySql: Fix password regression in MySQL datasource #20376

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

papagian
Copy link
Contributor

What this PR does / why we need it:
Fix regression caused by escaping delimiter character from password.
Escaping the password can be dropped since the driver is searching for the last occurrence of the delimiter.

Which issue(s) this PR fixes:

Fixes #20228

Special notes for your reviewer:

@papagian papagian added this to the 6.5.0-beta1 milestone Nov 14, 2019
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marefr marefr changed the title mysql: Fix password regression in MySQL datasource MySql: Fix password regression in MySQL datasource Nov 14, 2019
@papagian papagian merged commit 2ca1cc5 into master Nov 14, 2019
@papagian papagian deleted the 20228-mysql-regression branch November 14, 2019 10:16
aknuds1 pushed a commit that referenced this pull request Nov 14, 2019
kylebrandt pushed a commit that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Grafana 6.4.4 breaks MySQL login
2 participants