Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame: round trip metadata to arrow Table #21277

Merged
merged 5 commits into from
Jan 3, 2020
Merged

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Dec 29, 2019

This PR:

  • encodes and decodes DataFrame metadata (config, meta, etc)
  • moves files from dataframe/arrow/ArrowDataFrame to dataframe/ArrowDataFrame
  • makes apache-arrow an external dependency on @grafana/data

馃 phantomjs will like it!

// import { resultsToDataFrames } from '@grafana/data/dataframe/arrow/ArrowDataFrame'
//
// export * from './arrow/ArrowDataFrame';
export * from './ArrowDataFrame';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the external apache-arrow import, maybe phantomjs will be OK now?

@ryantxu ryantxu changed the title [WIP] DataFrame: round trip metadata to arrow Table DataFrame: round trip metadata to arrow Table Jan 3, 2020
@ryantxu ryantxu marked this pull request as ready for review January 3, 2020 06:07
@ryantxu ryantxu requested a review from dprokop January 3, 2020 06:07
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking solid, haven't found anything to comment on :)

@ryantxu ryantxu merged commit e550572 into master Jan 3, 2020
@ryantxu ryantxu deleted the arrow-roundtrip branch January 3, 2020 16:12
ryantxu added a commit that referenced this pull request Jan 4, 2020
* origin/master:
  NewsPanel: update default feed url (#21342)
  docs: fix influxdb templated dashboard link (#21336)
  Docs: Update Windows.md (#21333)
  Arrow: don't export arrow... breaking phantomjs e2e test (#21331)
  DataFrame: round trip metadata to arrow Table (#21277)
  Prometheus: user metrics metadata to inform query hints (#21304)
  Panel: disable edit/duplicate/delete entry for repeat panel (#21257)
  Prometheus: Disable suggestions at beginning of value (#21302)
  grafana/ui: Do not build in strict mode as grafana/ui depends on non-strict libs (#21319)
ryantxu added a commit that referenced this pull request Jan 6, 2020
* origin/master: (43 commits)
  Docs: Use https scheme for Grafana playground links (#21360)
  fix docs links (#21359)
  AddDatasourcePage: Refactoring & more Phantom plugins (#21261)
  Chore: Remove empty flot.pie file (#21356)
  Docs: Fix link (#21358)
  Docs: Fix InfluxDB templated dashboard link (#21343)
  Rendering: Fix panel PNG rendering when using sub url & serve_from_sub_path = true (#21306)
  NewsPanel: update default feed url (#21342)
  docs: fix influxdb templated dashboard link (#21336)
  Docs: Update Windows.md (#21333)
  Arrow: don't export arrow... breaking phantomjs e2e test (#21331)
  DataFrame: round trip metadata to arrow Table (#21277)
  Prometheus: user metrics metadata to inform query hints (#21304)
  Panel: disable edit/duplicate/delete entry for repeat panel (#21257)
  Prometheus: Disable suggestions at beginning of value (#21302)
  grafana/ui: Do not build in strict mode as grafana/ui depends on non-strict libs (#21319)
  Docs: Update security.md (#20981)
  @grafana/data: use timeZone parameter rather than isUtc (#21276)
  Units: support dynamic count and currency units (#21279)
  Docs: Added sudo and removed $ where inconsistent. (#21314)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants