Prometheus: Disable suggestions at beginning of value #21302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davkal
added this to Under review
in Observability (deprecated, use Observability Squad)
via automation
pracucci
reviewed
Dec 31, 2019
There was a problem hiding this comment.
It does what it says, but a bit a dubious about not triggering suggestions when the label value is empty. For example (the | is the cursor):
http_requests_total{namespace=~"|}shows suggestionshttp_requests_total{namespace=~"|"}doesn't show suggestions, while I would expect it to do
- fixed comparison operator regex - no longer suggest anything at beginning of label value
davkal
force-pushed
the
davkal/fix-prom-label-start-suggestion
branch
from
6bde3d9
to
2076355
Compare
Observability (deprecated, use Observability Squad)
automation
moved this from Under review
to Done
Jan 3, 2020
ryantxu
added a commit
that referenced
this pull request
Jan 4, 2020
* origin/master: NewsPanel: update default feed url (#21342) docs: fix influxdb templated dashboard link (#21336) Docs: Update Windows.md (#21333) Arrow: don't export arrow... breaking phantomjs e2e test (#21331) DataFrame: round trip metadata to arrow Table (#21277) Prometheus: user metrics metadata to inform query hints (#21304) Panel: disable edit/duplicate/delete entry for repeat panel (#21257) Prometheus: Disable suggestions at beginning of value (#21302) grafana/ui: Do not build in strict mode as grafana/ui depends on non-strict libs (#21319)
ryantxu
added a commit
that referenced
this pull request
Jan 6, 2020
* origin/master: (43 commits) Docs: Use https scheme for Grafana playground links (#21360) fix docs links (#21359) AddDatasourcePage: Refactoring & more Phantom plugins (#21261) Chore: Remove empty flot.pie file (#21356) Docs: Fix link (#21358) Docs: Fix InfluxDB templated dashboard link (#21343) Rendering: Fix panel PNG rendering when using sub url & serve_from_sub_path = true (#21306) NewsPanel: update default feed url (#21342) docs: fix influxdb templated dashboard link (#21336) Docs: Update Windows.md (#21333) Arrow: don't export arrow... breaking phantomjs e2e test (#21331) DataFrame: round trip metadata to arrow Table (#21277) Prometheus: user metrics metadata to inform query hints (#21304) Panel: disable edit/duplicate/delete entry for repeat panel (#21257) Prometheus: Disable suggestions at beginning of value (#21302) grafana/ui: Do not build in strict mode as grafana/ui depends on non-strict libs (#21319) Docs: Update security.md (#20981) @grafana/data: use timeZone parameter rather than isUtc (#21276) Units: support dynamic count and currency units (#21279) Docs: Added sudo and removed $ where inconsistent. (#21314) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20403