-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PublicDashboards: Add annotations support #56413
Merged
owensmallwood
merged 49 commits into
main
from
owensmallwood/pubdash-add-annotations-support
Oct 19, 2022
Merged
Changes from 13 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
a526987
Adds backend pubdash support for annotations
owensmallwood 8889988
Adds frontend support for pubdash annotations
owensmallwood baf4e58
dont get rules when its a public dashboard
owensmallwood ded15f6
Merge branch 'main' into owensmallwood/pubdash-add-annotations-support
owensmallwood 1db5187
Only send out request for grafana annotations. Don't support query an…
owensmallwood e420e4e
Adds permissions for getting annotations. Anonymous user needs to be …
owensmallwood 5091e31
regenerates mocks for pubdash service
owensmallwood fcb47a1
Adds validation for getting pubdash annotations
owensmallwood 9ee81c1
Fixes failing tests. Needed to provide annotations service.
owensmallwood e23cf1d
Adds tests for pubdash annotations api
owensmallwood 5f75198
formatting
owensmallwood a2eb4ba
Generates mock for annotations service
owensmallwood 1747f98
Adds pubdash service tests for getting annotations
owensmallwood 302535f
change annotations repo on http_server back to private
owensmallwood 0651445
JsonEditorSettings: Fix invisible json editor
kaydelaney 0b773a0
Merge branch 'main' into owensmallwood/pubdash-add-annotations-support
owensmallwood 9639d9a
Merge remote-tracking branch 'origin/fix-json-editor-settings' into o…
owensmallwood 8bb014f
Gets pubdash annotations from the backend in one request. WIP
owensmallwood 0afb9f4
Gathers all pubdash annotations on the backend. Uses default annotati…
owensmallwood 234287e
Merge branch 'main' into owensmallwood/pubdash-add-annotations-support
owensmallwood 6b8a9c8
Updates pubdash annotations tests
owensmallwood c28a48e
Excludes annotation queries when looping over dashboard annotations. …
owensmallwood a3ff68b
Updates test to make sure disabled dashboard annotations are excluded.
owensmallwood c200233
removes stuff from bad merge
owensmallwood 430f6df
removes more from bad merge
owensmallwood 0e5b6f9
Uses generated type for dashboard annotations. Adds cue schema for an…
owensmallwood 64b3406
regenerates pubdash service mock
owensmallwood d79798d
renames test helper function
owensmallwood 50a1e46
removes unused struct
owensmallwood 4000e10
adds comment
owensmallwood 23974b1
Adds tests to pubdash frontend ds
owensmallwood 9cfdcbc
adds support for tag annotation queries
owensmallwood c25e6d0
makes sure duplicate events are not returned. Events from tag queries…
owensmallwood cec0371
fixes failing frontend and backend tests for pubdash
owensmallwood ee705c8
Merge branch 'main' into owensmallwood/pubdash-add-annotations-support
owensmallwood feaa835
Makes a new schema for Annotation Target. Accidentally used the Panel…
owensmallwood 71feb57
some small refactors and cleanup
owensmallwood 346191e
Merge branch 'main' into owensmallwood/pubdash-add-annotations-support
owensmallwood e41cfc3
renames repo
owensmallwood 53c1cea
adds helpful comment
owensmallwood c59e3da
refactors scopes to use constants
owensmallwood ec55cd3
had to move internal package test helper to its own file in models pa…
owensmallwood 8dccc5d
formats imports. Removes helper function because linter says its a se…
owensmallwood acaf30f
Merge branch 'main' into owensmallwood/pubdash-add-annotations-support
owensmallwood 45550c1
If it's a tags annotation, don't scope query by dashboard id since ta…
owensmallwood 4e0437d
linter fix - ineffectual assignment to error
owensmallwood 27e5d6c
resolves PR comments. Moves some test helper functions into the tests…
owensmallwood 3f02f95
Merged master. Resolved conflicts.
owensmallwood 884ca8f
Merge branch 'main' into owensmallwood/pubdash-add-annotations-support
owensmallwood File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111 changes: 111 additions & 0 deletions
111
pkg/services/annotations/annotations_repository_mock.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does it need to be public? better if we we can avoid that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember needing it public for some reason when I started tinkering around with this card, but looks like I don't need it anymore. Changed it back to private!