Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip: TooltipPlugin refactoring #70872
Tooltip: TooltipPlugin refactoring #70872
Changes from 84 commits
0a0a4d9
06a2a34
1246e9c
5b24828
2356be1
7e220b1
246d1a0
b141390
2520535
713f5f7
3052675
a876781
67425a0
8e0ba90
b3df98f
7925d46
b1a5c4c
a6c8440
f194e44
cdcf813
48c9da3
7c70848
8a61ef8
ea0f24b
e70d2f3
ecef9b1
43b652e
6ed9211
32d334c
87e0988
a998f7c
75fa4e8
2d1f0d7
aa34ff7
ca3bf48
7303d24
da07239
a3cec47
b34a051
901b72b
f1c2a01
01c382c
bfecc7d
51284c5
2f05fe6
0d7d6e7
96f6626
1a83ebd
38af80b
efbb27d
148a72a
bcc2ffe
5b30a21
50fd858
fd9096c
e9fd266
a19980f
aa4f3d3
0ee514e
7c54b1d
8ca359b
7856689
2a1d3e5
a545cba
7d0d0a6
a11b1d2
1cb1946
f33dee2
56a48e5
1eebb07
d62b654
5ec472b
cb2904d
924a6c9
74f891b
328d1e3
2809748
9dceda3
5cfaf96
0962145
a6e23ec
b59a60f
1f28226
fe12ac2
8441022
cacf652
5ee5d31
e36350c
d562ffe
74cba56
c9d60f0
3c7b6d7
878ad53
3630963
9c32fec
e921ff8
2ddbce1
86a072d
b176eba
a9db1b0
2cd868a
612134e
abadf6d
c99cc10
3871576
dfeedc9
964c29f
5bc69c3
3e7e05e
dc8cd1d
b9ba513
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extend this interface with the original data frames array coming from the query runner? The context is time comparison (ref grafana/scenes#244) where multiple queries will be performed to provide different time windows. In the aligned data frame all data is within the dashboard time range. We will of course shift the data accordingly for uPlot to be able to render graphs (ref #72715), so the aligned frame will not contain the real timestamps for the comparison series.
What I was thinking here about is a way we can reach out and read from the original series for the data to be displayed. We have information about original frame indices on the aligned frame's field (think its called field origin).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we'll have to do something like this. i'm not sure we'll need the alignedframe here (or anywhere) in the future. even now, since the alignment happens at the values level, we could just run the alignment on the original frames and pass them down. still iterating, but will keep this in mind. 👍