This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pluginVersion option to gauge panel template. Add some additional options (based on ver. 6.7.3): threshold options, gauge title, gauge unit, value display, gauge orientation.
This naming is consistent with other panels.
Shared logic for creating dashboards for testing panels.
Adds support for @method
Duologic
reviewed
Jul 8, 2020
Duologic
approved these changes
Jul 27, 2020
@fty4 it's intended that
This field has been used for layout since version 5. However, Grafana will convert the In the meantime, you can add them like in the
|
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stat and gauge are modeled very similarly so I put them together in this PR.
I've tested them with both Grafana 7.0.5 (latest release) and 6.7.4 (latest release of major version 6). These can be selected by passing the
pluginVersion
parameter to either panel. Grafana version support was the biggest challenge this PR attempts to address. While Grafana does a good job of adapting older JSON models to current versions, we'd like to keep how we model them Grafonnet current so we can support new features.Closes #237.
Closes #221. This PR was cherry picked to get started on the gauge panel updates.