[tempo-distributed] Add capability to define additional ports on gateway service #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviscares
requested review from
annanay25,
joe-elliott,
mapno,
mdisibio,
swartz-k,
BitProcessor,
faustodavid and
zalegrala
as code owners
|
|
zanhsieh
changed the title
|
If this is a useful scenario, it would be great to have it documented a bit more? Is a bit vague imho. |
|
Hey, I updated the comment string a bit, but I am unsure on how to make it clearer, as it is a pretty flexible thing. |
|
It needs updating the docs, please run helm-docs and commit changes! |
This creates a way to use the gateway for more complex scenarios in combination with .Values.gateway.nginxConfig.httpSnippet. Signed-off-by: David Pusch <david.pusch@protofy.com>
|
I'm trying. XD Should be good now |
mapno
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a way to use the gateway for more complex scenarios in combination with .Values.gateway.nginxConfig.httpSnippet.