Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep datasource in next level dashboard + "Filter by cluster/job" fix #1222

Merged
merged 1 commit into from
May 6, 2024

Conversation

clementduveau
Copy link
Contributor

Hello team,

In the Fleet view for Windows and Linux (Linux is in another repo so I will fix it in another PR), we have 1 broken filter and 1 "sometimes" broken link.

Go to a Linux or Windows fleet overview and click on cluster or job in the table. It will break because the datasource is empty in the link.
Now select a non-default datasource, click on an instance. The next level dashboard is empty because the datasource is not part of the URL and so you end up on the default Prometheus which doesn't have your instance.

Simple fix: I added the datasource at the end of those URL.

@clementduveau
Copy link
Contributor Author

I saw that we are waiting on Prometheus to merge our refactor in node_exporter. So I am not going to touch that yet.

@v-zhuravlev
Copy link
Contributor

Thanks!

@v-zhuravlev v-zhuravlev merged commit a602a63 into master May 6, 2024
2 checks passed
@v-zhuravlev v-zhuravlev deleted the Fix-fleet-view-links branch May 6, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants