-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add a few more k6 browser examples #1430
Conversation
324c17b
to
4733668
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great work :) I haven't looked it entirely, but one question.
|
||
# Hybrid performance with k6 browser | ||
|
||
An alternative approach to [browser-based load testing](https://grafana.com/docs/k6/<K6_VERSION>/testing-guides/load-testing-websites/#browser-based-load-testing) that is much less resource-intensive is combining a low amount of virtual users for a browser test with a high amount of virtual users for a protocol-level test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is <K6 VERSION>
here correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've looked at the existing examples and seems to be correct :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's correct! It's how we handle versioned links in the Grafana docs, it'll change based on which version of the docs the user is in. So if they're seeing latest
, the links on that page will replace <K6_version>
with latest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! I made a few comments most of them are just to rewrite a few sentences to use active voice instead of passive to follow our style guide. 🤓
docs/sources/next/using-k6-browser/recommended-practices/hybrid-approach-to-performance.md
Outdated
Show resolved
Hide resolved
docs/sources/next/using-k6-browser/recommended-practices/hybrid-approach-to-performance.md
Outdated
Show resolved
Hide resolved
docs/sources/next/using-k6-browser/recommended-practices/hybrid-approach-to-performance.md
Outdated
Show resolved
Hide resolved
docs/sources/next/using-k6-browser/recommended-practices/hybrid-approach-to-performance.md
Outdated
Show resolved
Hide resolved
docs/sources/next/using-k6-browser/recommended-practices/hybrid-approach-to-performance.md
Outdated
Show resolved
Hide resolved
docs/sources/next/using-k6-browser/recommended-practices/hybrid-approach-to-performance.md
Outdated
Show resolved
Hide resolved
docs/sources/next/using-k6-browser/recommended-practices/hybrid-approach-to-performance.md
Outdated
Show resolved
Hide resolved
docs/sources/next/using-k6-browser/recommended-practices/hybrid-approach-to-performance.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
What?
This PR adds a few more examples of using k6 browser, mainly using custom metrics and hybrid performance.
Checklist
Please fill in this template:
make docs
command locally and verified that the changes look good.Select one of these and delete the others:
If updating the documentation for the most recent release of k6:
docs/sources/v{most_recent_release}
folder of the documentation.docs/sources/next
folder of the documentation.If updating the documentation for the next release of k6:
docs/sources/next
folder of the documentation.Related PR(s)/Issue(s)