Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner linking to Grafana docs #1432

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Add banner linking to Grafana docs #1432

merged 2 commits into from
Dec 6, 2023

Conversation

heitortsergent
Copy link
Collaborator

@heitortsergent heitortsergent commented Nov 29, 2023

What?

Add a banner to all the pages linking to the Grafana docs.

Screenshot 2023-11-29 at 3 54 57 PM

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.

@heitortsergent
Copy link
Collaborator Author

@ppcano I remembered we have the banner feature, similar to what we used for the forum migration.

What do you think if we use this for the docs as well? :)

@ppcano
Copy link
Collaborator

ppcano commented Nov 29, 2023

@heitortsergent nice catch, LGTM!

@heitortsergent heitortsergent marked this pull request as ready for review December 6, 2023 16:22
@heitortsergent heitortsergent merged commit 48aa20c into main Dec 6, 2023
5 checks passed
@heitortsergent heitortsergent deleted the add-banner-grafana branch December 6, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants