Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated param name from METRIC_NAME to METRIC_NAME1 on thresholds.md #1442

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

mustafasahin0
Copy link
Contributor

@mustafasahin0 mustafasahin0 commented Dec 5, 2023

What?

updated param name from METRIC_NAME to METRIC_NAME1 on thresholds.md to make it in sync with explanations in the documentation.

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the make docs command locally and verified that the changes look good.

Select one of these and delete the others:

If updating the documentation for the most recent release of k6:

  • I have made my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the relevant (e.g. when correcting a documentation error) folders of the previous k6 versions of the documentation.

If updating the documentation for the next release of k6:

  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

@heitortsergent
Copy link
Collaborator

@mustafasahin0 thanks for the PR! We just released k6 v0.48, would you mind making the change in this file as well? https://github.com/grafana/k6-docs/blob/main/docs/sources/v0.48.x/using-k6/thresholds.md?plain=1#L99

And thank you for filling out the PR template! 🙇

@mustafasahin0
Copy link
Contributor Author

Hi @heitortsergent :) Updated v0.48 as well

Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mustafasahin0!

@heitortsergent heitortsergent merged commit 1bb6a0e into grafana:main Dec 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants