Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor gRPC docs updates #1491

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Minor gRPC docs updates #1491

merged 3 commits into from
Feb 7, 2024

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jan 26, 2024

What?

It fixes a minor mistake on the gRPC protocol page, also linking the Protobuf JSON Mapping where we have examples and describes pitfalls.

Checklist

Please fill in this template:

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the make docs command locally and verified that the changes look good.

Select one of these and delete the others:

If updating the documentation for the most recent release of k6:

  • I have made my changes in the docs/sources/next folder of the documentation.
  • I have reflected my changes in the docs/sources/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant (e.g. when correcting a documentation error) folders of the previous k6 versions of the documentation.

If updating the documentation for the next release of k6:

  • I have made my changes in the docs/sources/next folder of the documentation.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov self-assigned this Jan 26, 2024
@olegbespalov olegbespalov added the Area: OSS Content Improvements or additions to community/oss documentation label Jan 26, 2024
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small edits, other than that LGTM! 🚢

docs/sources/next/using-k6/protocols/grpc.md Outdated Show resolved Hide resolved
docs/sources/next/using-k6/protocols/grpc.md Outdated Show resolved Hide resolved
Co-authored-by: Heitor Tashiro Sergent <heitortsergent@gmail.com>
@heitortsergent heitortsergent merged commit 7a1f263 into main Feb 7, 2024
6 checks passed
@heitortsergent heitortsergent deleted the chore/minor-gprc-docs-fixes branch February 7, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OSS Content Improvements or additions to community/oss documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants