Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop common.Bind and context-based utils #2385

Closed
Tracked by #2344
codebien opened this issue Feb 10, 2022 · 0 comments · Fixed by #2448
Closed
Tracked by #2344

Drop common.Bind and context-based utils #2385

codebien opened this issue Feb 10, 2022 · 0 comments · Fixed by #2448
Assignees
@codebien
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes refactor
Milestone
v0.38.0

Comments

@codebien
Copy link
Contributor

codebien commented Feb 10, 2022 •
edited
Loading

Remove the last call of common.Bind from

k6/js/initcontext.go

Line 213 in bee87c5

return i.runtime.ToValue(common.Bind(i.runtime, mod, i.ctxPtr)), nil

and remove the deprecated APIs - #2344
@codebien codebien mentioned this issue Feb 10, 2022
Closed
5 tasks
@codebien codebien changed the title Remove the last call of common.Bind from k6/js/initcontext.go Line 213 in bee87c5 return i.runtime.ToValue(common.Bind(i.runtime, mod, i.ctxPtr)), nil Drop common.Bind and context-based utils Feb 10, 2022
@codebien codebien added this to the v0.38.0 milestone Feb 10, 2022
@imiric imiric mentioned this issue Mar 10, 2022
Closed
imiric pushed a commit to grafana/xk6-browser that referenced this issue Mar 11, 2022
Attach k6 VU to context
1143fcf 
The k6 context-based utils were deprecated[1], and will be removed in
v0.38.0[2], so this attaches VU to the context so that its helper
functions can be used instead. Right now it will only be used for
RegisterCallback(), but we should move all other uses of it soon (mainly
GetRuntime()).

[1]: grafana/k6@335d99c

[2]: grafana/k6#2385
imiric pushed a commit to grafana/xk6-browser that referenced this issue Mar 11, 2022
Attach k6 VU to context
86921bd 
The k6 context-based utils were deprecated[1], and will be removed in
v0.38.0[2], so this attaches VU to the context so that its helper
functions can be used instead. Right now it will only be used for
RegisterCallback(), but we should move all other uses of it soon (mainly
GetRuntime()).

[1]: grafana/k6@335d99c

[2]: grafana/k6#2385
@codebien codebien mentioned this issue Mar 17, 2022
Merged
@na-- na-- added the breaking change for PRs that need to be mentioned in the breaking changes section of the release notes label Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codebien codebien

Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes refactor
Projects
None yet
Milestone
v0.38.0
Development

Successfully merging a pull request may close this issue.

Drop common.Bind and other context-based deprecated utils grafana/k6
2 participants
@codebien @na--