Fix the execution derivation bug and work around the k6 0.24.0 wrong tar metadata #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, since those options were included by k6 v0.24.0, only emit a warning instead of an error if the derived execution options match any `execution` options that are "specified" by the user, since at that level we can't distinguish if we're executing an archive or a script...
na--
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
+ Coverage 72.78% 72.79% +<.01%
==========================================
Files 133 133
Lines 9884 9905 +21
==========================================
+ Hits 7194 7210 +16
- Misses 2272 2278 +6
+ Partials 418 417 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
+ Coverage 72.78% 72.79% +<.01%
==========================================
Files 133 133
Lines 9884 9905 +21
==========================================
+ Hits 7194 7210 +16
- Misses 2272 2278 +6
+ Partials 418 417 -1
Continue to review full report at Codecov.
|
|
Seems that besides more tests, I'll have to make another change to the shortcut options, relating to this issue: #1058 |
golangcibot
reviewed
Jun 27, 2019
mstoykov
approved these changes
Jun 27, 2019
This would just produce a shared-iterations scheduler with the specified number of iterations and a maxDuration equal to the passed duration, similar to how it works in the current k6 execution. This should fix #1058.
na--
force-pushed
the
fix-execution-validation-bug
branch
from
7f9e39f
to
0109458
Compare
|
Just for posterity, here's an explanation why the bugfix part of this PR was insufficient: #1007 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two minor improvements + refactoring and a bugfix:
Include the k6 version in the tar archives' metadata.json
Do not include the derived execution options in tar archives
Also, since those options were included by k6 v0.24.0, only emit a warning instead of an error if the derived execution options match any
executionoptions that are "specified" by the user, since at that level we can't distinguish if we're executing an archive or a script...Allow simultaneous use of
durationanditerationsexecution shortcutsThis would just produce a shared-iterations scheduler with the specified number of iterations and a
maxDurationequal to the passedduration, similar to how it works in the current k6 execution. This should fix Specifying both duration and iterations is deprecated and won't be supported in the future k6 versions #1058.