Fix all the linter errors in cmd package #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will be posting some more fixes which will actually remove some of the problems, tomorrow. But all of those will be in separate PR based on this one |
Well most are silenced actually as a lot of them will require a lot of code changes.
codebien
approved these changes
Jan 17, 2022
| @@ -55,7 +55,7 @@ var ( | |||
| showCloudLogs = true | |||
| ) | |||
|
|
|||
| //nolint:funlen,gocognit,gocyclo | |||
| //nolint:funlen,gocognit,gocyclo,cyclop | |||
There was a problem hiding this comment.
Suggested change
| //nolint:funlen,gocognit,gocyclo,cyclop | |
| //nolint:funlen,gocognit,cyclop |
gocyclo has been disabled
There was a problem hiding this comment.
why didn't nolintlint told me that then 🤔
There was a problem hiding this comment.
There is an open question for it golangci/golangci-lint#2395
yorugac
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well most are silenced actually as a lot of them will require a lot of
code changes.