Try to load and parse the sourcemap before returning it #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully fix most of the cases where a source map that is tried to be loaded but turns out to be gibberish doesn't stop the whole execution of k6.
mstoykov
commented
Jan 27, 2022
na--
reviewed
Jan 27, 2022
na--
reviewed
Jan 27, 2022
Co-authored-by: na-- <n@andreev.sh>
codebien
approved these changes
Jan 27, 2022
na--
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix most of the cases where a source map that
is tried to be loaded but turns out to be gibberish doesn't stop the
whole execution of k6.
edit: this also fixes the error message about source map not being loaded, when goja also has other errors. Previous it would tell you stuff such as
when for example the source map wasn't loaded properly but also babel needs to be invoked in order to transpile import/export for example.