Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move InterruptError in errext and other refactorings #2536

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

mstoykov
Copy link
Contributor

This is mostly done so that ./lib/executor doesn't need to import
./js/common and goja

part of #2535

This is mostly done so that ./lib/executor doesn't need to import
./js/common and goja
@github-actions github-actions bot requested review from codebien and oleiade May 13, 2022 15:11
@mstoykov mstoykov added this to the v0.39.0 milestone May 18, 2022
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙇

@mstoykov mstoykov merged commit 582a2a7 into master Jun 1, 2022
@mstoykov mstoykov deleted the dontPullGojaFromLib branch June 1, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants