Update ui_unix.go with z/OS build flags #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added zos build flags for IBM z/OS compatibility
mstoykov
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
LGTM!
This seems pretty okay change, but the afero one will be more problematic as we have deliberately not updated it in quite a while and intend on actually deprecating it with #1079 .
So while we should likely still merge this - it might not be enough and even if afero merges the PR to their repo, we are unlikely to update it just to be z/OS compatibile :(.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added z/OS build flags for IBM z/OS compatibility.
Enabling these build flags (along with the changes to afero mentioned here spf13/afero#384) allows k6 to be compiled on z/OS Unix System Services.
Closes #2888