-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PR template #3131
Update PR template #3131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3131 +/- ##
==========================================
+ Coverage 73.86% 73.89% +0.03%
==========================================
Files 243 243
Lines 18492 18488 -4
==========================================
+ Hits 13659 13662 +3
+ Misses 3964 3960 -4
+ Partials 869 866 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, thanks for taking care of it.
db2e107
to
dafbf69
Compare
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
@olegbespalov can you set clearly the expectations about it? Do you expect us as reviewers will add and check all of them? |
Hey @codebien .
TL;DR: No, I don't expect any reviewers to mark checkbox items. This checklist is, first of all, for the casual k6's contributors. The idea is to help quickly figure out what is necessary to check even before the code review starts. But I believe it helps also non-casual contributors, even us as maintainers. So the pull request creator should mark the checkboxes, that are applicable to the current case context. |
Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>
What?
Simplifies and add structure to the pull requests template.
Why?
Having checklists is a common practice where we can explicitly ask (or later refer) contributors/maintainers if they have done some essential things like (self-review, linters, and test runs).