Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint version update & minor fixes #3177

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jul 7, 2023

What?

Update the golangci lint to the latest version and fix some nolint (linter is not used) issues.

Why?

The reason behind this is a minor inconvenience after the changes for the deepguard linter that caused inline reporting of the blocked package.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@github-actions github-actions bot requested review from imiric and oleiade July 7, 2023 12:57
@olegbespalov olegbespalov changed the title Chore/golangci lint update golangci-lint version update & minor fixes Jul 7, 2023
@olegbespalov olegbespalov self-assigned this Jul 7, 2023
mstoykov
mstoykov previously approved these changes Jul 7, 2023
@olegbespalov olegbespalov added this to the v0.46.0 milestone Jul 7, 2023
.golangci.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #3177 (5bc644a) into master (a2fe0a8) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 5bc644a differs from pull request most recent head f408018. Consider uploading reports for the commit f408018 to get more accurate results

@@            Coverage Diff             @@
##           master    #3177      +/-   ##
==========================================
- Coverage   72.82%   72.78%   -0.04%     
==========================================
  Files         255      253       -2     
  Lines       19611    19606       -5     
==========================================
- Hits        14281    14270      -11     
- Misses       4433     4435       +2     
- Partials      897      901       +4     
Flag Coverage Δ
ubuntu 72.78% <ø> (+0.02%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/bundle.go 85.90% <ø> (ø)
js/compiler/compiler.go 63.52% <ø> (ø)
js/modules/k6/k6.go 98.24% <ø> (ø)
js/summary.go 89.87% <ø> (ø)
lib/executor/base_config.go 84.21% <ø> (ø)
lib/executor/constant_arrival_rate.go 96.68% <ø> (ø)
lib/executor/ramping_arrival_rate.go 96.55% <ø> (ø)
lib/netext/httpext/response.go 100.00% <ø> (ø)
lib/netext/httpext/transport.go 97.08% <ø> (ø)
lib/runtime_options.go 100.00% <ø> (ø)

... and 9 files with indirect coverage changes

@olegbespalov olegbespalov merged commit 199bf4e into master Jul 10, 2023
@olegbespalov olegbespalov deleted the chore/golangci-lint-update branch July 10, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants