-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golangci-lint version update & minor fixes #3177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
changed the title
Chore/golangci lint update
golangci-lint version update & minor fixes
Jul 7, 2023
mstoykov
previously approved these changes
Jul 7, 2023
codebien
reviewed
Jul 7, 2023
Codecov Report
@@ Coverage Diff @@
## master #3177 +/- ##
==========================================
- Coverage 72.82% 72.78% -0.04%
==========================================
Files 255 253 -2
Lines 19611 19606 -5
==========================================
- Hits 14281 14270 -11
- Misses 4433 4435 +2
- Partials 897 901 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mstoykov
approved these changes
Jul 10, 2023
codebien
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the golangci lint to the latest version and fix some
nolint
(linter is not used) issues.Why?
The reason behind this is a minor inconvenience after the changes for the
deepguard
linter that caused inline reporting of the blocked package.Checklist
make ci-like-lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)