Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping the CI & Dockerfile to go 1.21 #3283

Merged
merged 2 commits into from Sep 19, 2023
Merged

Bumping the CI & Dockerfile to go 1.21 #3283

merged 2 commits into from Sep 19, 2023

Conversation

olegbespalov
Copy link
Collaborator

@olegbespalov olegbespalov commented Aug 16, 2023

What?

This change switches the default's go version used for building k6 to go1.21.

Why?

The go 1.21 is the current default version of the go.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint), and all checks pass.
  • I have run tests locally (make tests), and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Changelog

internal: Updates CI & Dockerfile to go 1.21

This switches the default's go version used for building k6 to go1.21.

@olegbespalov olegbespalov added this to the v0.47.0 milestone Aug 16, 2023
Copy link
Collaborator

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I would prefer if we wait for a .1 release, it seems there are already a bunch of issues reported https://github.com/golang/go/milestone/328

@olegbespalov
Copy link
Collaborator Author

olegbespalov commented Aug 16, 2023

Sure, we could wait for merging for the first patch release, but in fact, there will be no changes in the code of the PR

@mstoykov
Copy link
Collaborator

Can we also update the commit and PR name to specify this is bumping the CI to 1.21

@olegbespalov
Copy link
Collaborator Author

@mstoykov we could, but this PR updates the Dockerfile, so it's not only about CI. However, if you still think that the commit message/PR title bumping the CI to 1.21 fits better I don't mind updating it.

@olegbespalov olegbespalov changed the title bump go to 1.21 Bumping the CI & Dockerfile to go 1.21 Aug 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (2640a6b) 73.17% compared to head (373f0a9) 73.16%.

❗ Current head 373f0a9 differs from pull request most recent head 4fc6cb0. Consider uploading reports for the commit 4fc6cb0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3283      +/-   ##
==========================================
- Coverage   73.17%   73.16%   -0.02%     
==========================================
  Files         258      258              
  Lines       19912    19912              
==========================================
- Hits        14571    14569       -2     
- Misses       4416     4418       +2     
  Partials      925      925              
Flag Coverage Δ
ubuntu 73.04% <ø> (-0.08%) ⬇️
windows 73.01% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olegbespalov
Copy link
Collaborator Author

@mstoykov Anyway, I think maybe you meant more commit's atomicity, so I've tried to split it into the parts. Let me know if that works or additional details ☺️

mstoykov
mstoykov previously approved these changes Aug 17, 2023
@mstoykov
Copy link
Collaborator

@olegbespalov I mostly wanted for it to specify we don't just ... I don't know start using 1.21 features and users need 1.21 to compile

oleiade
oleiade previously approved these changes Aug 17, 2023
@olegbespalov
Copy link
Collaborator Author

Ah, I see, make sense 👍

Updating the version of the go that is using for building k6 in CI and
Dockerfile.
@olegbespalov olegbespalov merged commit 433f21b into master Sep 19, 2023
21 checks passed
@olegbespalov olegbespalov deleted the chore/go-update branch September 19, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants