-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumping the CI & Dockerfile to go 1.21 #3283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I would prefer if we wait for a .1
release, it seems there are already a bunch of issues reported https://github.com/golang/go/milestone/328
Sure, we could wait for merging for the first patch release, but in fact, there will be no changes in the code of the PR |
Can we also update the commit and PR name to specify this is bumping the CI to 1.21 |
@mstoykov we could, but this PR updates the Dockerfile, so it's not only about CI. However, if you still think that the commit message/PR title |
eab1378
to
52e681d
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3283 +/- ##
==========================================
- Coverage 73.17% 73.16% -0.02%
==========================================
Files 258 258
Lines 19912 19912
==========================================
- Hits 14571 14569 -2
- Misses 4416 4418 +2
Partials 925 925
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mstoykov Anyway, I think maybe you meant more commit's atomicity, so I've tried to split it into the parts. Let me know if that works or additional details |
@olegbespalov I mostly wanted for it to specify we don't just ... I don't know start using 1.21 features and users need 1.21 to compile |
Ah, I see, make sense 👍 |
Updating the version of the go that is using for building k6 in CI and Dockerfile.
52e681d
to
4fc6cb0
Compare
What?
This change switches the default's go version used for building k6 to go1.21.
Why?
The go 1.21 is the current default version of the go.
Checklist
make ci-like-lint
), and all checks pass.make tests
), and all tests pass.Related PR(s)/Issue(s)
Changelog
internal: Updates CI & Dockerfile to go 1.21
This switches the default's go version used for building k6 to go1.21.