Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable -race for Windows test #3366

Closed
wants to merge 1 commit into from
Closed

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Oct 3, 2023

What?

Why?

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@codebien codebien self-assigned this Oct 3, 2023
@codebien codebien changed the title ci: Use same setup on Windows as for the other platforms Enable -race for Windows test Oct 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f35e679) 72.95% compared to head (158d3d2) 72.96%.

❗ Current head 158d3d2 differs from pull request most recent head a816b1f. Consider uploading reports for the commit a816b1f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3366   +/-   ##
=======================================
  Coverage   72.95%   72.96%           
=======================================
  Files         280      280           
  Lines       20938    20938           
=======================================
+ Hits        15275    15277    +2     
+ Misses       4693     4691    -2     
  Partials      970      970           
Flag Coverage Δ
macos 72.89% <ø> (+<0.01%) ⬆️
ubuntu 72.90% <ø> (+<0.01%) ⬆️
windows 72.81% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien closed this Aug 28, 2024
@codebien codebien deleted the keep-race-flag-windows-ci branch August 28, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants