Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring of the CSV output #3462

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Nov 21, 2023

What?

This pull request fixes the linter issues in the output/CSV package.

Why?

As we agreed, we aim to fix most of the linter issues.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Part of #769

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (a087d42) 73.23% compared to head (7e743a6) 73.22%.

❗ Current head 7e743a6 differs from pull request most recent head 7b774ce. Consider uploading reports for the commit 7b774ce to get more accurate results

Files Patch % Lines
output/csv/output.go 65.00% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3462      +/-   ##
==========================================
- Coverage   73.23%   73.22%   -0.01%     
==========================================
  Files         267      267              
  Lines       20083    20087       +4     
==========================================
+ Hits        14707    14709       +2     
  Misses       4463     4463              
- Partials      913      915       +2     
Flag Coverage Δ
ubuntu 73.15% <66.66%> (-0.01%) ⬇️
windows 73.07% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olegbespalov olegbespalov changed the title Chore/output csv linter Minor refactoring of the CSV output Nov 21, 2023
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thanks!

@codebien codebien requested review from a team and joanlopez and removed request for mstoykov and a team November 21, 2023 09:52
@olegbespalov olegbespalov merged commit 6d6fb72 into master Dec 7, 2023
22 checks passed
@olegbespalov olegbespalov deleted the chore/output-csv-linter branch December 7, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants