Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x/crypto and x509roots/fallback - no actual changes #3513

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

mstoykov
Copy link
Contributor

What?

Update x/crypto and x509roots/fallback

Why?

There is moderate security issue - one that we do not actually hit.

It still will be nice to not get flagged by scanners.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.49.0 milestone Dec 19, 2023
@mstoykov mstoykov requested a review from a team as a code owner December 19, 2023 08:19
@mstoykov mstoykov requested review from oleiade and codebien and removed request for a team December 19, 2023 08:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f49b98a) 72.44% compared to head (41344a7) 72.46%.

❗ Current head 41344a7 differs from pull request most recent head dfb3452. Consider uploading reports for the commit dfb3452 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3513      +/-   ##
==========================================
+ Coverage   72.44%   72.46%   +0.01%     
==========================================
  Files         274      274              
  Lines       20837    20837              
==========================================
+ Hits        15096    15099       +3     
+ Misses       4774     4771       -3     
  Partials      967      967              
Flag Coverage Δ
ubuntu 72.46% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mstoykov mstoykov merged commit 7d131d6 into master Dec 19, 2023
21 checks passed
@mstoykov mstoykov deleted the updateXCrypto branch December 19, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants