Fix k6-insights enabled check #3529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use raw `Bool` instead of `ValueOrZero` to fetch a real underlying value, no matter if set by default or by user.
Blinkuu
requested review from
mstoykov and
olegbespalov
and removed request for
a team
mstoykov
approved these changes
Jan 11, 2024
olegbespalov
previously approved these changes
Jan 11, 2024
vortegatorres
previously approved these changes
Jan 11, 2024
mstoykov
dismissed stale reviews from vortegatorres and olegbespalov
via
6e9532c
mstoykov
approved these changes
Jan 12, 2024
olegbespalov
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use raw
Boolinstead ofValueOrZero.Why?
If the value hasn't been set by the user, the default value set to
truein #3398 was not respected.Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
Fixes a bug introduced in #3398.