Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to grafana URLs #3543

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jan 16, 2024

What?

This PR switches the URLs from the k6.io/docs/ to the grafana.com/docs/k6/latest/

Why?

grafana.com/docs/k6/latest/ is the primary source of the documentation right now.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov requested a review from a team as a code owner January 16, 2024 08:20
@olegbespalov olegbespalov requested review from mstoykov and codebien and removed request for a team January 16, 2024 08:20
mstoykov
mstoykov previously approved these changes Jan 16, 2024
mstoykov
mstoykov previously approved these changes Jan 16, 2024
@mstoykov mstoykov added this to the v0.49.0 milestone Jan 16, 2024
README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f35e679) 72.95% compared to head (8f21347) 72.90%.

❗ Current head 8f21347 differs from pull request most recent head d7c8ecf. Consider uploading reports for the commit d7c8ecf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3543      +/-   ##
==========================================
- Coverage   72.95%   72.90%   -0.05%     
==========================================
  Files         280      278       -2     
  Lines       20938    20936       -2     
==========================================
- Hits        15275    15264      -11     
- Misses       4693     4698       +5     
- Partials      970      974       +4     
Flag Coverage Δ
macos ?
ubuntu 72.90% <100.00%> (+<0.01%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olegbespalov olegbespalov merged commit d031d2b into master Jan 16, 2024
23 of 25 checks passed
@olegbespalov olegbespalov deleted the feat/switching-to-grafana-urls branch January 16, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants